Skip to content

Refactor LambdaLift #12724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2021
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 6, 2021

Break out the dependency collection into a separate class.
That makes it more re-usable and makes LambdaLift itself
easier to understand.

odersky added 5 commits June 6, 2021 11:47
Break out the dependency collection into a separate class.
That makes it more re-usable and makes LambdaLift itself
easier to understand.
@abgruszecki
Copy link
Contributor

Should I review this?

@odersky
Copy link
Contributor Author

odersky commented Jun 8, 2021

@abgruszecki Please go ahead!

Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abgruszecki abgruszecki merged commit a63bedd into scala:master Jun 13, 2021
@abgruszecki abgruszecki deleted the refactor-lambdalift branch June 13, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants